Seed three demo sandboxes in setup_demo (one nested)#4775
Open
elias-ba wants to merge 2 commits into
Open
Conversation
Security Review ✅
|
- Alias Lightning.Projects.Sandboxes at module top to satisfy Credo's nested-module check. - Extend the setup_demo/1 @SPEC with the new :sandboxes key so Dialyzer's contract check matches the returned map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lightning.SetupUtils.setup_demo/1now provisions three sandboxes after seeding the two demo projects:openhie-devunder OpenHIE,dhis2-devunder DHIS2, anddhis2-feature-xnested underdhis2-dev. This makes the sandbox UX (list, picker, breadcrumb truncation, nested provisioning) demonstrable on a fresh demo instance without any extra setup.Closes #4774.
Validation steps
Lightning.SetupUtils.setup_demo(create_super: true)from IEx, orIS_RESETTABLE_DEMO=yes mix run priv/repo/demo.exs.demo@openfn.org/welcome12345). Visit DHIS2 → Sandboxes and OpenHIE → Sandboxes. Each shows its dev sandbox; DHIS2's also showsdhis2-feature-xnested underdhis2-dev.super@openfn.org). DHIS2 is not in the picker; OpenHIE → Sandboxes showsopenhie-dev.AI Usage
Pre-submission checklist