Skip to content

Add notebook for ABFE result analysis#235

Merged
IAlibay merged 6 commits into
mainfrom
abfe_analysis
Oct 21, 2025
Merged

Add notebook for ABFE result analysis#235
IAlibay merged 6 commits into
mainfrom
abfe_analysis

Conversation

@hannahbaumann

Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hannahbaumann hannahbaumann changed the title [ WIP ] Add notebook for ABFE result analysis Add notebook for ABFE result analysis Oct 14, 2025
@hannahbaumann hannahbaumann requested a review from IAlibay October 14, 2025 12:23
Comment thread abfe_tutorial/abfe_analysis.ipynb
Comment thread abfe_tutorial/abfe_analysis.ipynb
Comment thread abfe_tutorial/abfe_analysis.ipynb
Comment thread abfe_tutorial/abfe_analysis.ipynb
Comment thread abfe_tutorial/abfe_analysis.ipynb

@IAlibay IAlibay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @hannahbaumann - few comments / things to change. One thing at the start - what version of the ABFE branch was used to generate the results? Serialization changed recently because we changed the Boresch restraint settings, so that broke the ability to read old JSON files.

@hannahbaumann hannahbaumann requested a review from IAlibay October 21, 2025 08:46
@hannahbaumann

Copy link
Copy Markdown
Contributor Author

@IAlibay I had changed the few settings entries, so it can still load the jsons!

@IAlibay IAlibay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@IAlibay IAlibay enabled auto-merge October 21, 2025 11:03
@IAlibay IAlibay merged commit 30cdca9 into main Oct 21, 2025
4 checks passed
@IAlibay IAlibay deleted the abfe_analysis branch October 21, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants