Skip to content

TaskStatusDB: Test for _task_row_update_statement - #25

Draft
dwhswenson wants to merge 4 commits into
mainfrom
taskstatusdb-test-task-row-update
Draft

TaskStatusDB: Test for _task_row_update_statement#25
dwhswenson wants to merge 4 commits into
mainfrom
taskstatusdb-test-task-row-update

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

I promised more detailed unit tests for this function in #21. Here they are.

@codecov

codecov Bot commented Jul 27, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (2cffa62) to head (cd63885).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   86.62%   91.63%   +5.00%     
==========================================
  Files           5        5              
  Lines         344      526     +182     
==========================================
+ Hits          298      482     +184     
+ Misses         46       44       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dwhswenson
dwhswenson marked this pull request as draft October 5, 2023 18:20
@dwhswenson

Copy link
Copy Markdown
Member Author

Putting this on hold (as draft) because I think it might have conflicts with #31. Part of this PR involves actually testing the SQL that gets emitted; this was intended as a way to give a clear picture of what is happening behind the scenes. But the SQL that gets emitted might be dialect-specific.

I'll come back to finish this after #31 is merged in (prefer to get that in and have the conflict block here than the other way around).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant