refactor: use a task type table instead of a column - #53
Open
ethanholz wants to merge 3 commits into
Open
Conversation
Use the task_types schema consistently for single-task and network inserts, enforce one task type per task, and update tests and user documentation for the separate table. BREAKING CHANGE: We removed the task type column. Assisted-by: Pi:openai-codex/gpt-5.6-sol
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 99.06% 98.90% -0.16%
==========================================
Files 6 6
Lines 532 548 +16
==========================================
+ Hits 527 542 +15
- Misses 5 6 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #49 . This model was originally used in the benchmarking_orchestration project. For more information on the original implementation see here: https://github.com/omsf-eco-infra/benchmarking-orchestration/blob/51200f79f1d220c1253d869a0018b322dedad301/src/benchmarking_orchestration/tasks/__init__.py#L53-L134
This code was slimmed down and implemented partially by me and 152de01 was created using an agent with direction from my first commit. It is important to note that this is a breaking change because it removes the task type column but this change is optional for all but any clients who may have used exorcist in the last week (this is of little concern).
Assisted-by: Pi:openai-codex/gpt-5.6-sol