Skip to content

refactor: use a task type table instead of a column - #53

Open
ethanholz wants to merge 3 commits into
mainfrom
refactor/task-type-table
Open

refactor: use a task type table instead of a column#53
ethanholz wants to merge 3 commits into
mainfrom
refactor/task-type-table

Conversation

@ethanholz

Copy link
Copy Markdown
Collaborator

This PR closes #49 . This model was originally used in the benchmarking_orchestration project. For more information on the original implementation see here: https://github.com/omsf-eco-infra/benchmarking-orchestration/blob/51200f79f1d220c1253d869a0018b322dedad301/src/benchmarking_orchestration/tasks/__init__.py#L53-L134

This code was slimmed down and implemented partially by me and 152de01 was created using an agent with direction from my first commit. It is important to note that this is a breaking change because it removes the task type column but this change is optional for all but any clients who may have used exorcist in the last week (this is of little concern).

Assisted-by: Pi:openai-codex/gpt-5.6-sol

Use the task_types schema consistently for single-task and network
inserts, enforce one task type per task, and update tests and user 
documentation for the separate table.

BREAKING CHANGE: We removed the task type column.

Assisted-by: Pi:openai-codex/gpt-5.6-sol
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.90%. Comparing base (9cfe24e) to head (a375da5).

Files with missing lines Patch % Lines
exorcist/taskdb.py 91.42% 3 Missing ⚠️
exorcist/tests/test_taskstatusdb.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   99.06%   98.90%   -0.16%     
==========================================
  Files           6        6              
  Lines         532      548      +16     
==========================================
+ Hits          527      542      +15     
- Misses          5        6       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor task_type from 1-1 to 1-many

1 participant