Skip to content

make file storage create directory upon instantiation - #827

Draft
atravitz wants to merge 2 commits into
mainfrom
feat/filestorage_create_on_init
Draft

make file storage create directory upon instantiation#827
atravitz wants to merge 2 commits into
mainfrom
feat/filestorage_create_on_init

Conversation

@atravitz

@atravitz atravitz commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Makes FileStorage behave more similarly to expected Pathlib behavior.
This also enables better error handling and guardrails for FileSystemWarehouse, as mentioned in OpenFreeEnergy/openfe#2155 (comment).

As written, this PR breaks existing behavior. Setting exist_ok=True by default would keep existing behavior. In my opinion, since ExternalStorage isnt used elsewhere yet, we should stick with the safer exist_ok=False option, but I can be convinced otherwise.

** LLM / AI generated code disclosure **

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
If yes, please provide details here:

Checklist

  • Added a news entry
  • Filled in the AI-generated code disclosure.

Developers certificate of origin

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (0b0edd9) to head (f96c37d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          43       43           
  Lines        2819     2820    +1     
=======================================
+ Hits         2781     2782    +1     
  Misses         38       38           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz
atravitz force-pushed the feat/filestorage_create_on_init branch from e4ced4e to 430e600 Compare August 15, 2026 02:01
@atravitz atravitz self-assigned this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant