Skip to content

remove perses atommapper and scorer#1943

Merged
atravitz merged 8 commits into
mainfrom
remove_perses
Jun 29, 2026
Merged

remove perses atommapper and scorer#1943
atravitz merged 8 commits into
mainfrom
remove_perses

Conversation

@atravitz

@atravitz atravitz commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

resolves #1635

We communicated to the board that we will be removing these in v1.11.0. My only concern is that I originally said v2.0 in the changelog.

To be thorough, we can give this one more deprecation cycle where we update the changelog to say "will be removed in v1.12.0" so that users have appropriate heads-up.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.61%. Comparing base (903f31c) to head (9a284e5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
- Coverage   94.93%   90.61%   -4.32%     
==========================================
  Files         217      212       -5     
  Lines       20774    20572     -202     
==========================================
- Hits        19721    18642    -1079     
- Misses       1053     1930     +877     
Flag Coverage Δ
fast-tests 90.61% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz added this to the 1.12.0 milestone Apr 27, 2026
@atravitz

Copy link
Copy Markdown
Contributor Author

(looks like API break check is working as expected @mikemhenry!)

@atravitz atravitz marked this pull request as ready for review June 26, 2026 22:05

@IAlibay IAlibay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unused fixture (blocking over that one) and one nit, otherwise it looks good to me.

Comment thread src/openfe/tests/setup/atom_mapping/test_perses_scorers.py
Comment thread docs/installation.rst Outdated
@github-actions

Copy link
Copy Markdown

🚨 API breaking changes detected! 🚨

View workflow run

Griffe output
$ griffe check "openfe" -s src --no-inspection --no-color --verbose -a origin/main
src/openfe/setup/atom_mapping/perses_mapper.py:0: <module>:
Public object was removed

src/openfe/setup/atom_mapping/perses_scorers.py:0: <module>:
Public object was removed

src/openfe/tests/setup/atom_mapping/test_perses_atommapper.py:0: <module>:
Public object was removed

src/openfe/tests/setup/atom_mapping/conftest.py:0: <module>:
Public object was removed

src/openfe/tests/setup/atom_mapping/test_perses_scorers.py:0: <module>:
Public object was removed


$ griffe check "openfecli" -s src --no-inspection --no-color --verbose -a origin/main

@atravitz atravitz merged commit 7ad6a25 into main Jun 29, 2026
9 of 10 checks passed
@atravitz atravitz deleted the remove_perses branch June 29, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vendor needed perses code (or remove)

2 participants