remove perses atommapper and scorer#1943
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
==========================================
- Coverage 94.93% 90.61% -4.32%
==========================================
Files 217 212 -5
Lines 20774 20572 -202
==========================================
- Hits 19721 18642 -1079
- Misses 1053 1930 +877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
(looks like API break check is working as expected @mikemhenry!) |
IAlibay
requested changes
Jun 28, 2026
IAlibay
left a comment
Member
There was a problem hiding this comment.
One unused fixture (blocking over that one) and one nit, otherwise it looks good to me.
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
|
🚨 API breaking changes detected! 🚨 Griffe output |
IAlibay
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1635
We communicated to the board that we will be removing these in v1.11.0. My only concern is that I originally said v2.0 in the changelog.
To be thorough, we can give this one more deprecation cycle where we update the changelog to say "will be removed in v1.12.0" so that users have appropriate heads-up.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin