Move structural analysis methods to child classes in SepTop Protocol - #2049
Open
IAlibay wants to merge 9 commits into
Open
Move structural analysis methods to child classes in SepTop Protocol#2049IAlibay wants to merge 9 commits into
IAlibay wants to merge 9 commits into
Conversation
Contributor
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
hannahbaumann
marked this pull request as ready for review
August 14, 2026 09:45
IAlibay
commented
Aug 14, 2026
|
|
||
| **Changed:** | ||
|
|
||
| * The per-phase trajectory analysis in the SepTop protocol is now run |
Member
Author
There was a problem hiding this comment.
I wouldn't include a news item for this - it's an internal re-arrangement for somewhat private unit methods. Putting it in the human-readable changelog is probably more likely to confuse users than anything else.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
- Coverage 95.19% 90.58% -4.62%
==========================================
Files 213 213
Lines 21104 21138 +34
==========================================
- Hits 20091 19147 -944
- Misses 1013 1991 +978
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No API break detected ✅ Griffe output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2041
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin