Price Correction for Re-Croc Potted Items - #326
Open
FinnHornhoover wants to merge 4 commits into
Open
FinnHornhoover wants to merge 4 commits into
FinnHornhoover wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, croc potted items' buy price would effectively be the stats items used for their croc pot. This PR changes that to be their style item, i.e. how it looks determines its buy price. This allows the client and server to always agree on the correct, deducted price when re-croc potting items, even if they have been croc potted before.
A known issue remains: re-croc potted items will appear to also use their levels and rarity from the style item while the client calculates the success odds. This is incorrect behavior on the client's part, i.e. level and rarity, much like armor and offense numbers, should come from the stats item. We can't meaningfully fix the displayed chance in this edge case, and server already behaves correctly.