Support custom class lookup in Wire conversion (#806) - #807
Draft
maxim-ponomarev wants to merge 3 commits into
Draft
maxim-ponomarev wants to merge 3 commits into
maxim-ponomarev wants to merge 3 commits into
Conversation
yevgenp
force-pushed
the
#806-Support-custom-ClassLookup-in-WireTypeConverter
branch
from
January 30, 2024 14:22
95d5159 to
05fa50e
Compare
Contributor
|
@maxim-ponomarev I've adjusted the test (as per |
yevgenp
force-pushed
the
#806-Support-custom-ClassLookup-in-WireTypeConverter
branch
from
January 30, 2024 20:20
05fa50e to
609b4be
Compare
yevgenp
reviewed
Jan 30, 2024
|
|
||
| public class UnknownClassLookup implements ClassLookup { | ||
| public static final CachedCompiler CACHED_COMPILER = | ||
| new CachedCompiler(Jvm.isDebug() ? new File(OS.getTarget(), "generated-test-sources") : null, null); |
Contributor
There was a problem hiding this comment.
This class should be moved to test sources or target has to be adjusted respectively.
|
Member
|
c.f. #823 |
peter-lawrey
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ClassLookupconstructor overloads toWireTypeConverterand share the supplied lookup between YAML and JSON conversion. Retain validation and propagate lookup failures through the converter.The draft also introduces a lookup wrapper that generates map-backed classes for unknown type names, with YAML/JSON/YAML round-trip tests.
This remains a draft. Review the public exception-signature change, qualified-name and alias handling, generated-class ownership and restoration of global Wire test settings. The discussion also points to #823; reconcile that related work before choosing a delivery path.
Validation: the diff and recorded review/check history were inspected at
609b4becef47. No build, test or benchmark was rerun for this metadata edit. No CI result was returned for this head.