fix(types): create Feature TypedDict for critic refinement module - #792
Open
github-actions[bot] wants to merge 1 commit into
Open
fix(types): create Feature TypedDict for critic refinement module#792github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Replaces dict[str, Any] with a proper Feature TypedDict for critic feature dictionaries (e.g., agent behavioral issues). This improves type safety and IDE support. Changes: - Added Feature TypedDict with name, display_name, and probability fields - Updated all function signatures in refinement.py to use Feature - Removed unused Any import Addresses item from code quality report. Closes #790 Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Author
|
This PR is stale because it has been open for 40 days with no activity. Remove the stale label or leave a comment, otherwise it will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates a proper
FeatureTypedDict to replacedict[str, Any]for critic feature dictionaries, improving type safety and IDE support.Changes
FeatureTypedDict inopenhands_cli/tui/utils/critic/refinement.pywith fields:name: strdisplay_name: strprobability: floatFeatureinstead ofdict[str, Any]:_format_feature_for_prompt()get_high_probability_issues()build_refinement_message()should_trigger_refinement()AnyimportRelated Issue
Addresses findings from #790 (item #6 from the Low-Hanging Fruit section)
Testing
make lint)make test- 1361 tests)This PR was automatically generated by the Code Quality Report workflow.