fix(stores): add caching to CliSettings.load() - #797
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
Add a class-level cache (keyed by config path) to avoid repeated disk I/O when loading CLI settings. The cache: - Uses config path as key to handle mocked paths in tests - Is updated when save() is called - Can be explicitly cleared via clear_cache() - Supports refresh=True parameter to force reload Addresses item from code quality report. Closes #795
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a class-level cache to
CliSettings.load()to avoid repeated disk I/O when loading CLI settings. This addresses the performance issue where settings were being read from disk on every call.Changes
_cache: ClassVar[dict[Path, CliSettings]]class attribute to store cached settingsload()now returns cached value if available (unlessrefresh=True)save()updates the cache after writing to diskclear_cache(path=None)method to clear all or specific cache entriesRelated Issue
Addresses findings from #795 (Item 8: Add caching to
CliSettings.load())Testing
make lint)make test)This PR was automatically generated by the Code Quality Report workflow.