🏗️🔧：authenticate the EditorConfig download - #1835
Merged
Merged
Conversation
verify.validForEC fetches the editorconfig-checker binary from the GitHub API the first time it runs, and node_modules is new on every run here, so it fetches on every run. Unauthenticated that is 60 requests an hour shared with everything else leaving the same address, and #1834 failed on it having changed nothing that could possibly be related. The wrapper reads GITHUB_TOKEN and the runner is handed one, so the request is now authenticated and the limit is 5000. The binary is a Go program with no maintained JavaScript equivalent: eclint was last published in 2018 and editorconfig-tools in 2015. The npm package is the wrapper, and downloading is what it does. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
OpenINFbot
approved these changes
Aug 19, 2026
openinf-commit-queue
Bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1834 failed CI having changed a Liquid template and an Eleventy global. The
task that failed was
verify.validForEC:Nothing about a copyright year can reach an EditorConfig checker. It was the
runner's address being rate limited.
Why it happens
editorconfig-checkeron npm is a wrapper. The checker itself is a Go binary,which the wrapper fetches from the GitHub API the first time it runs and caches
under
node_modules. CI installs fresh every run, so it fetches every run.Unauthenticated, that is 60 requests an hour for the whole IP, shared with
every other job leaving the same address. It works until it does not, and when
it does not the failure lands on whichever pull request happened to be next.
The fix
The wrapper reads
GITHUB_TOKEN, confirmed in its bundle:The runner is handed a token already, so passing it makes the request
authenticated and the limit 5000.
On avoiding the download
It caches under
node_modules, so locally it downloads once. There is nomaintained JavaScript equivalent to move to:
eclinteditorconfig-toolsDownloading a binary is what this package is for, and the alternative would be
caching
node_modulesbetween runs, which is more machinery than this needs.Not done here
The wrapper also reads
EC_VERSION, and without it the version resolves tolatest, so CI runs whatever was released most recently. Pinning it would makethe checks reproducible and would want a renovate annotation to keep the pin
watched, the way
.devcontainer/post-create.shalready does. That is aseparate change and this one is the flake.