💄🔧:lift the navbar links off the ink - #1838
Merged
Merged
Conversation
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bootstrap's dark navbar draws its links at white 55%, which on our ink is 6.04:1. It clears AA and still reads washed. 78% is 10.93:1. That leaves the current page without a marker, since it was white among greys. It takes a rule in the brand teal instead, sitting on the bar's bottom edge, and the `aria-current` that belongs beside the class. The sidebar is untouched: not `navbar-dark`, and already marked down its left. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
DerekNonGeneric
force-pushed
the
fix/navbar-link-contrast
branch
from
August 20, 2026 23:18
ae01246 to
b2c2db8
Compare
OpenINFbot
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap's dark navbar draws its links at white 55%. Against our ink that
measures 6.04:1 — it clears AA, but only just, and at that size it reads washed
rather than quiet.
78% is nearly double the contrast and still sits back from the page it is
pointing at.
The part that came with it
The current page was marked by being white among greys. Once the greys are
lifted to 78% that distinction nearly vanishes, and it was a weak marker to
begin with: colour alone, no second cue, and nothing announced to a screen
reader.
So the current link now takes a rule under it in
$primary, and thearia-current="page"that should always have gone alongside theactiveclass. Marked twice, and one of the two is not visual.
Scope
Both rules are
.navbar-dark, which is the fixed top bar and nothing else. Themobile sidebar is a plain
.navbaron$secondary, so its links were neverpart of this, and it already marks the current page with a border down its
left.
aria-currentis added in both navs, since the sidebar deserves it equally.Checks
nps testpasses, all 17 verifiers.vnuclean on/,/about/and/news/. Confirmed in the built output thatactiveandaria-currentlandon Home from
/and About from/about/.How it came up
Reviewing the home page in #1833. It is site-wide, so it is here on its own.