💄🔧:keep the docs index styles off the docs pages - #1845
Merged
Conversation
The index and every page under it carry the same `docs` body class, so the index's resets reached all thirteen: `margin: 0` on their headings, paragraphs and lists, and `list-style: none` on the lists. 123 paragraphs, 31 headings and 14 lists rendered without spacing, and the lists without bullets. Scoping the resets to `main` was not enough, because the pages have a `main` of their own. The index now carries `docs-index` as well and its styles read that, so `docs` means only what the navigation reads it for. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
OpenINFbot
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs.liquidgives every page under/docs/the body classdocs, which isthe class the index's own styles read. So the index's resets applied to all
thirteen pages beneath it:
That is 123 paragraphs, 31 headings and 14 lists rendering with no spacing,
and lists with neither bullets nor indent. The contributing guide, the
commit-message page and the command-line syntax page are the worst hit, being
the longest.
Scoping to
mainwas meant to keep those resets off the navbar and footer,and it does. It gives no protection against another layout sharing the body
class, because that layout has a
maintoo.The fix
The index carries
docs-indexalongsidedocs, and its stylesheet reads thenew one.
docsgoes back to meaning only what the navigation uses it for, sothe Docs item still highlights on the index and on every page under it.
Checks
nps testpasses, all 17. No rule matches.docs mainany more. The indexrenders identically: 307 words, 9 handbook rules, 6 marked unwritten, "3 of 9
written", 4 community docs. Nav highlighting confirmed on the index, on a doc
page, and on the home page.
Not in scope
The pages themselves are still on the old shell:
deep-page.liquidputs themin a 48ch column wrapped in
.grid,.unit,.four-fifthsand.improve,none of which are styled anywhere. That is a redesign, and it is next.