Skip to content

Merge feature branch for auto-generation of Liberty features GA update#511

Open
TrevCraw wants to merge 55 commits intomainfrom
generate-features-update
Open

Merge feature branch for auto-generation of Liberty features GA update#511
TrevCraw wants to merge 55 commits intomainfrom
generate-features-update

Conversation

@TrevCraw
Copy link
Copy Markdown
Contributor

@TrevCraw TrevCraw commented Apr 21, 2026

No description provided.

turkeylurkey and others added 30 commits April 8, 2025 11:56
@turkeylurkey
Specify version 24.0.0.2 for binary scanner
3ba3b8e 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #474 from turkeylurkey/issue-1874a
5646c12 
Specify version 24.0.0.2 for binary scanner
@turkeylurkey
Add string for temp dir for generate features
8159bbd 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Add generateToSrc option to dev mode
8a9d6c5 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Toggle generateToSrc option using hotkey
b04e985 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey @TrevCraw
Update src/main/java/io/openliberty/tools/common/plugins/util/DevUtil…
495a118 
….java

Co-authored-by: Trevor Crawford <TrevCraw@users.noreply.github.com>
@turkeylurkey
Merge pull request #476 from turkeylurkey/issue-1892
5877cc8 
Add generateToSrc option to dev mode
@turkeylurkey
Handle the generateToSrc option in devmode
ba2777d 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Update test case
fea5c1c 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Display the correct info message when server file is in a temp dir
b94075a 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Better comments
c89b196 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Add constant for generated features overrides directory
a14c7ec 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Add support for feature gen to server dir for class file change
b0a2ab8 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Clean up method copyTempFeatureFileToServer
c73102d 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Keep temp generate features file in configDropins dir even in temp dir
a6f7106 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
generatFeaturesFile is either configDir or tempDir
52fe283 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
When you press hotkey o optionally generate to temp dir
49cbf35 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Register the generated features temp dir with the file watcher
4c0052a 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Remove code added to process the generated features file in favour of…
b8679df 
… processing by the file watcher

Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Use generateToSrc option in generate features after config file deletion
bc93cb1 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Register gen. features file to watch in dev mode
3ae5530 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Update copyright
67d7b34 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Clarify a comment
980d066 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Rename a method to make more sense
502d3db 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Rename a field
1c6fb16 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #479 from turkeylurkey/issue-1897a
16d3050 
Handle generateToSrc option in dev mode
@turkeylurkey
Rename generate features fields
a42ffc8 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #493 from turkeylurkey/issue-1952
d384f65 
Rename generate features fields
@turkeylurkey
Copy config and changed file to temp dir for feature generation
5905974 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Code review updates: remove unneccessary directory and update comments
2fd65f3 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
turkeylurkey and others added 25 commits February 3, 2026 17:53
@turkeylurkey
Merge pull request #494 from turkeylurkey/issue-1959
1de62ee 
Copy config and changed file to temp dir for feature generation
@turkeylurkey
Pass the generateToSrc option when generating features
877e147 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Code review: rename variable and update comment
2e59317 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #495 from turkeylurkey/issue-1963
5c0f9b2 
Pass the generateToSrc option when generating features
@turkeylurkey
Fix merge conflicts
f1261b5 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #497 from turkeylurkey/merge-main-0130
22403f6 
Merge main into the latest generate features branch
@turkeylurkey
Make optimizeGenerateFeatures() protected
1eb9ff4 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Remove unused method getJavaSourceClassPaths()
7b2bf2f 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Track when generate-features file is copied early to prevent copying …
79a1d16 
…twice

Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #500 from turkeylurkey/issue-1967
6167b7e 
Make optimizeGenerateFeatures() available to ci.maven and ci.gradle
@turkeylurkey
Add coordinates for feature files
bde6685 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Add feature list file parameters to binary scanner
e8eba65 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Update the type of file to find for liberty base feature list
7f137d0 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Reduce the duplication in the feature list coordinates
515e3a8 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Remove debug statement
e43e66e 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Rework: clarify the name of open liberty Maven coordinates
4a34e59 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #506 from turkeylurkey/issue-1981
0d1c691 
Support a new API in the binary scanner
@TrevCraw
Updated user facing output
8f717ff
@turkeylurkey
Use the binary scanner API with a Map
ab17bc3 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@TrevCraw
Merge pull request #508 from TrevCraw/message-updates
7d5552a 
Updated user facing output
@turkeylurkey
Rework, rename variable
a3d7d38 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Rework, rename variable no. 2
3aa3cb8 
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey
Merge pull request #509 from turkeylurkey/issue-2001
a1230dd 
Use the binary scanner API with a Map
@turkeylurkey
Merge branch 'main' into generate-features-update
72e02b9
@turkeylurkey
Merge pull request #510 from turkeylurkey/merge-main-0421
fc4b382 
Merge main 0421
venmanyarun
venmanyarun requested changes Apr 23, 2026
View reviewed changes
Comment thread src/main/java/io/openliberty/tools/common/plugins/util/BinaryScannerUtil.java
public static final String BINARY_SCANNER_MAVEN_ARTIFACT_ID = "binary-app-scanner";
public static final String BINARY_SCANNER_MAVEN_TYPE = "jar";
public static final String BINARY_SCANNER_MAVEN_VERSION = "[25.0.0.2,)";
public static final String BINARY_SCANNER_MAVEN_VERSION = "[25.0.0.2.2]";
Copy link
Copy Markdown
Contributor

@venmanyarun venmanyarun Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to use a fixed version always?

Copy link
Copy Markdown
Contributor Author

@TrevCraw TrevCraw Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per release, yes it will be a fixed version

Comment thread src/main/java/io/openliberty/tools/common/plugins/util/BinaryScannerUtil.java
public Set<String> reRunBinaryScanner(Set<String> allClassesDirectories, String logLocation, String targetJavaEE, String targetMicroProfile)
throws PluginExecutionException {
Set<String> featureList = null;
public Set<String> reRunBinaryScanner(Set<String> allClassesDirectories, String logLocation, String targetJavaEE, String targetMicroProfile,
Copy link
Copy Markdown
Contributor

@venmanyarun venmanyarun Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that runBinaryScanner and rerunBinaryScanner handle the same binary scanner exceptions completely differently
is this intentional ?

example
PROVIDED_FEATURE_EXCEPTION
runBinaryScanner approach:

  1. Throws NoRecommendationException if no alternatives found
  2. Throws RecommendationSetException if alternatives exist

rerunBinaryScanner approach:

Logs debug message: "RuntimeException from re-run of binary scanner"
Returns null

Copy link
Copy Markdown
Contributor Author

@TrevCraw TrevCraw Apr 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intentional. The contexts to call runBinaryScanner and rerunBinaryScanner are different. We only call rerunBinaryScanner when there was an error from the binary scanner with the initial runBinaryScanner call. The second call to binary scanner in rerunBinaryScanner is intended to get a pure binary scanner recommended feature list for the application (i.e., analyze the whole application and ignore user-specified features). Because the contexts are different, the exceptions from the binary scanner are handled differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@venmanyarun venmanyarun venmanyarun requested changes

@cherylking cherylking Awaiting requested review from cherylking

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevCraw @venmanyarun @turkeylurkey