-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(upload): add optional system file filtering for uploads #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ignore_system_files setting (default: false) - Created IsSystemFile utility function to detect .DS_Store, desktop.ini, Thumbs.db, and ._* files - Integrated filtering into HTTP, WebDAV, FTP, and SFTP upload handlers - When enabled, common system files are rejected during upload Co-authored-by: jyxjjj <[email protected]>
Co-authored-by: jyxjjj <[email protected]>
- Integrated system file filtering into S3 PutObject handler - S3 uploads now also respect the ignore_system_files setting Co-authored-by: jyxjjj <[email protected]>
Copilot
AI
changed the title
[WIP] Add filter for Apple Double files in macOS
Add optional system file filtering for uploads (.DS_Store, ._* files)
Nov 13, 2025
Copilot finished work on behalf of
jyxjjj
November 13, 2025 05:26
ILoveScratch2
previously approved these changes
Nov 13, 2025
Member
|
@ILoveScratch2 再看一眼 |
KirCute
requested changes
Nov 13, 2025
KirCute
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS disk mapping and Windows file operations generate metadata files (
.DS_Store,desktop.ini,Thumbs.db,._*) that pollute storage when uploaded. This adds an opt-in filter.Changes
ignore_system_files(boolean, default: false) in global settingsutils.IsSystemFile()detects.DS_Store,desktop.ini,Thumbs.db, and Apple Double files (._*)FsStream,FsFormhandlershandlePutmethodPutObjectmethodWhen enabled, filtered files return 403 with "system file upload ignored".
Setting is disabled by default to preserve existing behavior.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.