Group and rename FLOPS based wetted areas together as a new group WettedAreaGroup#1010
Open
xjjiang wants to merge 36 commits intoOpenMDAO:mainfrom
Open
Group and rename FLOPS based wetted areas together as a new group WettedAreaGroup#1010xjjiang wants to merge 36 commits intoOpenMDAO:mainfrom
xjjiang wants to merge 36 commits intoOpenMDAO:mainfrom
Conversation
…ep_geom.py to wetted_area_total.py
…, _Fuselage to Fuselage_SWet, _BWBWing to BWBWing_SWet, _BWBFuselage to BWBFuselage_SWet, Bacelle to Nacelle_SWet, Canard to Canard_SWet.
| ] | ||
| }, | ||
| "outputs": [], | ||
| "outputs": [ |
Member
There was a problem hiding this comment.
You should clear the outputs from the output cells, which is easy to do from the jupyter-notebook application.
| from parameterized import parameterized | ||
|
|
||
| from aviary.subsystems.geometry.flops_based.canard import Canard | ||
| from aviary.subsystems.geometry.flops_based.canard import Canard_SWet |
Member
There was a problem hiding this comment.
Python style guidelines recommend that underscores should only be used in module and variable names. Classes should use camel-case. So, I think for all of these, something like CanardWettedArea would be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves and renames the following geometric objects in FLOPS based geometry subsystem to a new group
WettedAreaGroup:_PrelimtoPrelim_SWet_WingtoWing_SWet_TailtoTail_SWet_FuselagetoFuselage_SWet_BWBWingtoBWBWing_SWet_BWBFuselagetoBWBFuselage_SWetNacelletoNacelle_SWetCanardtoCanard_SWetComponent names are changed so that they are more descriptive. The most tricky update lies in
CombinedGeometrywhere both GASP and FLOPS geometries are used.Related Issues
Backwards incompatibilities
None
New Dependencies
None