Skip to content

Add a define to recognize osgos builds - #52

Merged
Capostrophic merged 4 commits into
OpenMW:3.6from
glassmancody:osgosg_define
Oct 7, 2026
Merged

Capostrophic merged 4 commits into
OpenMW:3.6from
glassmancody:osgosg_define

Conversation

@glassmancody

Copy link
Copy Markdown

No description provided.

@AnyOldName3

Copy link
Copy Markdown
Member

It looks like there are some other places that carry the version info and should probably have the OSGoS version:

  • PlatformSpecifics\Windows\OpenSceneGraphVersionInfo.rc.in
  • Maybe applications\osgversion\osgversion.cpp (as it's an application rather than an example, it's likely packaged on distros, and a sensible way to query whether they're using our fork).
  • I don't think the CPack stuff is worth touching
  • Doxygen stuff probably is
  • So's the pkgconfig stuff
  • Just regex search for OPENSCENEGRAPH_(MAJOR_)?VERSION and see if anything looks like it's supposed to have version info that might benefit from labelling it specifically as our fork.

@glassmancody

Copy link
Copy Markdown
Author

It looks like there are some other places that carry the version info and should probably have the OSGoS version:

  • PlatformSpecifics\Windows\OpenSceneGraphVersionInfo.rc.in
  • Maybe applications\osgversion\osgversion.cpp (as it's an application rather than an example, it's likely packaged on distros, and a sensible way to query whether they're using our fork).
  • I don't think the CPack stuff is worth touching
  • Doxygen stuff probably is
  • So's the pkgconfig stuff
  • Just regex search for OPENSCENEGRAPH_(MAJOR_)?VERSION and see if anything looks like it's supposed to have version info that might benefit from labelling it specifically as our fork.

OK, not sure if this is best approach but I added a new version string which just concatenates the regular version string with some suffix. I use this in doxygen and pckconfig.

Added for Mac SET(MACOSX_BUNDLE_INFO_STRING "OpenSceneGraph ${OSGOS_VERSION_STRING}"). Not sure if this is needed but I also don't think it hurts considering there's plenty of other ways to know what version you're on.

I added an option to query the osgos version from osgversion.cpp app (--osgos-version-number option).

Built doxygen, it looks like this, which matches changes to pkgconfig

image

Comment thread applications/osgversion/osgversion.cpp Resolved
@AnyOldName3

Copy link
Copy Markdown
Member

If we want to go all-out, I suppose there are a bunch of places the strings OpenSceneGraph or openscenegraph are used that could potentially be changed to OpenSceneGraph on Steroids, but I'm not certain that's a good idea, and even if it is, it might be best left to its own PR.

@Capostrophic
Capostrophic merged commit 0e70c2e into OpenMW:3.6 Oct 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants