Open
Conversation
Final Update for the Com6Scarp Script. Includes minor changes like changes in attribute names and meanings
fso42
requested changes
Dec 15, 2025
Contributor
fso42
left a comment
fso42
left a comment
There was a problem hiding this comment.
Is the removal and moving of the coordinates and perimeter points wanted?
Contributor
Author
|
performed the requestted correction
fso42
requested changes
Dec 18, 2025
Contributor
fso42
left a comment
fso42
left a comment
There was a problem hiding this comment.
The points_coordinates files are duplicated. I think one set should be removed?
Comment on lines
+86
to
+87
| planesDip = list(map(float, SHPdata['dipdir'])) | ||
| planesSlope = list(map(float, SHPdata['dipAngle'])) |
Contributor
There was a problem hiding this comment.
I strongly sugget to match the variable names and the attribute name. I.e planesDipAngle. Otherwise this gets very confusing when reading the code
Comment on lines
+116
to
+119
| ellipsoidsTilt = list(map(float, SHPdata['dipAngle'])) | ||
| ellipsoidsDir = list(map(float, SHPdata['dipdir'])) | ||
| ellipsoidsOffset = list(map(float, SHPdata['offset'])) | ||
| ellipsoidDip = list(map(float, SHPdata['dip'])) | ||
| ellipsoidDip = list(map(float, SHPdata['rotAngle'])) |
| ellipsoidsTilt = list(map(float, SHPdata['tilt'])) | ||
| ellipsoidsDir = list(map(float, SHPdata['direc'])) | ||
| ellipsoidsTilt = list(map(float, SHPdata['dipAngle'])) | ||
| ellipsoidsDir = list(map(float, SHPdata['dipdir'])) |
Contributor
There was a problem hiding this comment.
please use dipDir (capital D; since it gets changed anyways...)
| slopeAngle | ||
| np array with the slope angle of each scarp plane-feature (as many values as features) | ||
| dip | ||
| dipdir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final Update for the Com6Scarp Script.
Includes minor changes like changes in attribute names and meanings