Repository navigation
B #8194: Read READ_LENGTH in market_mad/s3/import - #8196
Closed
trukhinyuri wants to merge 2 commits into
Closed
trukhinyuri wants to merge 2 commits into
trukhinyuri wants to merge 2 commits into
Conversation
Read MARKETPLACE/TEMPLATE/READ_LENGTH (with fallback to READx_LENGTH) in src/market_mad/remotes/s3/import so the configured S3 chunk size is applied during marketplace imports. Signed-off-by: Iurii Trukhin <yuri@trukhin.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly satisfies issue #8194 without introducing unresolved problems.
0 open findings
What changed in this PR
Corrects S3 marketplace imports to honor the configured chunk size while retaining backward compatibility.
Changes:
- Reads
READ_LENGTHfirst. - Falls back to legacy
READx_LENGTH.
| File | Description |
|---|---|
src/market_mad/remotes/s3/import |
Corrects chunk-size template lookup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
When READ_LENGTH converts to zero, IO#read(0) keeps returning an empty string and the importer repeatedly uploads empty parts. Negative values raise ArgumentError after S3 setup. Reject non-positive values before creating the S3 client. Keep the default chunk size, legacy READx_LENGTH fallback and existing positive integer conversion. Signed-off-by: Iurii Trukhin <yuri@trukhin.com>
Contributor
Author
|
Could a maintainer approve the Smoke Tests and Check Protected Files runs for |
paczerny
approved these changes
Oct 31, 2026
Member
|
merged as per 88bb097 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8194.
src/market_mad/remotes/s3/import, readMARKETPLACE/TEMPLATE/READ_LENGTH(with a fallback toMARKETPLACE/TEMPLATE/READx_LENGTH) so the configured S3 chunk size is honored during marketplace image imports.Branches to which this PR applies