Skip to content

B #8214: Do not clear ETHx_* context variables on NIC detach if NETWORK is not YES - #8215

Closed
mcanevet wants to merge 1 commit into
OpenNebula:masterfrom
mcanevet:fix/keep-eth-context-network-no
Closed

mcanevet wants to merge 1 commit into
OpenNebula:masterfrom
mcanevet:fix/keep-eth-context-network-no

Conversation

@mcanevet

Copy link
Copy Markdown
Contributor

Description

B #8214. Do not remove the ETHx_* CONTEXT variables when a NIC is detached and NETWORK is not YES: in that case they are user-defined and nothing generates them back.

Branches to which this PR applies

  • master
  • one-X.X

  • Check this if this PR should not be squashed

…h if NETWORK is not YES

When a NIC is detached, its ETHx_* variables are removed from the VM CONTEXT
whatever the value of NETWORK is. With NETWORK=NO, OpenNebula does not generate
those variables: they are defined by the user, and nothing generates them back
when the NIC is attached again. Guests that read their network configuration
from the CONTEXT at every boot lose their network.

Only clear them when NETWORK=YES, the same condition generate_network_context()
uses to decide whether OpenNebula manages them.

Signed-off-by: Mickaël Canévet <mickael.canevet@proton.ch>
@mcanevet mcanevet closed this Oct 21, 2026
@mcanevet mcanevet reopened this Oct 21, 2026
@rsmontero

Copy link
Copy Markdown
Member

Merged as per dfd6b3d

@rsmontero rsmontero closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants