Set username then password fields for SMB printer#233
Open
sibskull wants to merge 1 commit intoOpenPrinting:masterfrom
Open
Set username then password fields for SMB printer#233sibskull wants to merge 1 commit intoOpenPrinting:masterfrom
sibskull wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
Usually for SMB authentication the username field is used first, then the password field. This commit set this order for new SMB printer pane.
Member
|
Hi Andrey, I'm sorry for the late answer - I'm currently occupied with other things, so I haven't managed to test the PR yet. I'll ping you back once I'll test the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually for SMB authentication the username field is used first, then the password field.
This commit set this order for new SMB printer pane.