Fix major bug when computing the measure of a point after unnamed anchor #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristramg
force-pushed
the
fix_unnamed_anchor
branch
from
5e244aa to
7a69275
Compare
woshilapin
reviewed
Dec 18, 2025
| .anchors | ||
| .windows(2) | ||
| .find(|window| window[1].curve_position() >= curve_position) | ||
| .or_else(|| self.anchors.windows(2).last()) |
Contributor
There was a problem hiding this comment.
I don’t understand how this helps, shouldn’t we error instead of providing this fallback which does not provide anchors on each side of the curve_position. If it is really helpful, maybe a comment to explain why would help?
EDIT: discuss yesterday, there is a reason for this, yet, a comment might be useful, or a test maybe?
Contributor
Author
There was a problem hiding this comment.
I added a comment. The test existed, but I added an explicit comment
This could result in a big drift when both part didn’t progress at the same pace Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg
force-pushed
the
fix_unnamed_anchor
branch
from
7a69275 to
6bb4412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could result in a big drift when both part didn’t progress at the same pace
Closes https://github.com/osrd-project/osrd-data-issues/issues/888