Document ACP protocol research#608
Closed
AnthonyRonning wants to merge 1 commit into
Closed
Conversation
Deploying maple with
|
| Latest commit: |
bd3c5b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd5c619b.maple-ca8.pages.dev |
| Branch Preview URL: | https://codex-acp-support-maple.maple-ca8.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
📝 WalkthroughWalkthroughAdds a single new documentation file, ChangesACP Research Documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/agent-client-protocol-research.md`:
- Around line 48-66: The snapshot references in the research doc expose
workstation-specific /Users/admin checkout paths, including the repository
entries and the running log, so sanitize those identifiers everywhere they
appear. Update the research section and any related log text to use neutral
aliases or repo-relative labels instead of local filesystem paths, keeping the
repository names, snapshot commits, and file lists intact. Refer to the Goose
and agent-client-protocol snapshot entries in the doc so the replacements stay
consistent across the repeated sections.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 11b8e4ae-2208-4950-ba77-9d4281090cae
📒 Files selected for processing (1)
docs/agent-client-protocol-research.md
Comment on lines
+48
to
+66
| - Repository: https://github.com/agentclientprotocol/agent-client-protocol | ||
| - Local snapshot: `/Users/admin/repos/ThirdParties/agent-client-protocol` | ||
| - Snapshot commit: `dbe946b docs: update registry agents (#1628)` | ||
| - Key files: | ||
| - `README.md` | ||
| - `schema/v1/meta.json` | ||
| - `schema/v1/meta.unstable.json` | ||
| - `schema/v2/meta.json` | ||
| - `schema/v2/meta.unstable.json` | ||
| - `docs/protocol/v1/*.mdx` | ||
| - `docs/protocol/v2/*.mdx` | ||
|
|
||
| Goose: | ||
|
|
||
| - Repository: https://github.com/aaif-goose/goose | ||
| - Local snapshot: `/Users/admin/repos/ThirdParties/goose-upstream` | ||
| - Snapshot commit: `6d69936 chore: Remove stale crates/goose-server and update docs (#10224)` | ||
| - Also present: `/Users/admin/repos/goose-v1.39.0` is a dirty existing checkout | ||
| and was not modified. |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Redact the local checkout paths.
The /Users/admin/... paths leak workstation-specific details and make the doc hard to reuse. Replace them with sanitized aliases or repo-relative identifiers, including the same entries in the running log.
♻️ Example sanitization
- - Local snapshot: `/Users/admin/repos/ThirdParties/agent-client-protocol`
+ - Local snapshot: `<local checkout>/agent-client-protocol`Also applies to: 82-106, 1279-1286
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/agent-client-protocol-research.md` around lines 48 - 66, The snapshot
references in the research doc expose workstation-specific /Users/admin checkout
paths, including the repository entries and the running log, so sanitize those
identifiers everywhere they appear. Update the research section and any related
log text to use neutral aliases or repo-relative labels instead of local
filesystem paths, keeping the repository names, snapshot commits, and file lists
intact. Refer to the Goose and agent-client-protocol snapshot entries in the doc
so the replacements stay consistent across the repeated sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by CodeRabbit