Skip to content

Fix Progress bar width#5875

Open
Borreg0 wants to merge 17 commits intoOpenSlides:mainfrom
Borreg0:5855-ExpandableProgressBar
Open

Fix Progress bar width#5875
Borreg0 wants to merge 17 commits intoOpenSlides:mainfrom
Borreg0:5855-ExpandableProgressBar

Conversation

@Borreg0
Copy link
Contributor

@Borreg0 Borreg0 commented Feb 13, 2026

Resolves a part of #5855

@Borreg0 Borreg0 added enhancement General enhancement which is neither bug nor feature ui labels Feb 13, 2026
@Elblinator Elblinator requested review from MSoeb and removed request for Elblinator February 16, 2026 06:48
@Elblinator Elblinator assigned MSoeb and unassigned Elblinator Feb 16, 2026
@Borreg0 Borreg0 mentioned this pull request Feb 16, 2026
7 tasks
@Borreg0 Borreg0 marked this pull request as draft February 16, 2026 14:43
@Borreg0 Borreg0 assigned Borreg0 and unassigned bastianjoel and MSoeb Feb 16, 2026
@Borreg0 Borreg0 marked this pull request as ready for review February 17, 2026 11:42
@Borreg0 Borreg0 assigned bastianjoel and MSoeb and unassigned Borreg0 Feb 17, 2026
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make a few changes:

  1. When languages are switched, the size of the bar always changes and the distance to the text on the left also changes.

To fix this problem, the bar should be narrower overall so that it remains in the same position even when languages are switched.

Use the Russian translation as a reference, as it has the longest text length.

  1. Small screens: The content should still be visible on small devices even with the bar. The mat cards and the content should fit in a format, which fits the screen space.

Example of unreadable content.
image

  1. Alignment of gender numbers: The alignment of the sub gender numbers should be in line with the overall value.

See: The numbers left of the red line should be in line aswell.
Ausrichtung

@MSoeb MSoeb assigned Borreg0 and unassigned MSoeb Feb 19, 2026
@Borreg0 Borreg0 assigned MSoeb and unassigned Borreg0 Feb 23, 2026
@Borreg0 Borreg0 force-pushed the 5855-ExpandableProgressBar branch 2 times, most recently from 381216e to f8af6b2 Compare February 25, 2026 10:51
@Elblinator Elblinator assigned Borreg0 and unassigned bastianjoel and MSoeb Feb 25, 2026
@Borreg0 Borreg0 assigned bastianjoel and MSoeb and unassigned Borreg0 Feb 26, 2026
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional changes are required.

1. Matcard on small screens like smartphones: The matcard should not be scrollable horizontally on small devices. The matcard should fit the screen size. I've tested it with a Pixel 8 and on a iPhone SE. I can slightly be moved. Here a video example of it.

5875.-.moveable.Matcard.mp4

2. Total value and numbers of genders under it: The values should be aligned like in the mockup.

Affected area:
Image

3. Problem with the text to the left and right of the progress bar:
There are several issues occurring simultaneously here. First, switching languages causes the progress bar to shift. This is clearly visible when you change the language from German to Russian. Second, the spacing between the progress bar and the text on the right is too small, which doesn’t look good visually.

To solve both problems, I would suggest making the progress bar slightly shorter overall. This would create more space on the left and right side, which, in my opinion, would resolve the issue.

@MSoeb MSoeb assigned Borreg0 and unassigned MSoeb and bastianjoel Mar 17, 2026
@Borreg0 Borreg0 requested review from Elblinator and removed request for bastianjoel March 23, 2026 15:36
@Borreg0 Borreg0 requested a review from MSoeb March 23, 2026 15:36
@MSoeb MSoeb mentioned this pull request Mar 24, 2026
@Borreg0
Copy link
Contributor Author

Borreg0 commented Mar 27, 2026

I am not sure if the class bar-height is useful. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General enhancement which is neither bug nor feature ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants