Enhance SRT parsing and optimize subtitle loading. Also some EventInfo fixes#1244
Merged
Huevos merged 1 commit intoOpenViX:Developerfrom Mar 30, 2026
Merged
Enhance SRT parsing and optimize subtitle loading. Also some EventInfo fixes#1244Huevos merged 1 commit intoOpenViX:Developerfrom
Huevos merged 1 commit intoOpenViX:Developerfrom
Conversation
…for SRT parsing [EventInfo] Small enhancements [SubRip] Optimized parsing of SRT subs
Contributor
|
Looks good ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to subtitle parsing and event handling, focusing on performance, maintainability, and feature support. The most notable changes include a major refactor of the
SubRipParserfor faster and more robust SRT subtitle parsing, additional event handling inEventInfo.py, and improved subtitle loading logic.Subtitle Parsing Improvements:
SubRipParserinSubRip.py:Event Handling Enhancements:
EventInfo.pynow listens for two new service events:evUpdateTagsandevUpdateIDv3Cover, ensuring that the UI responds to more metadata changes.gotEventwhere the internal service reference is now correctly cleared on all relevant events, improving state consistency.Subtitle Loader Logic:
loadSubtitlesinSubtitleRenderer.pyto return a boolean indicating success, clarifying the method’s contract and simplifying error handling for SRT subtitles.