Support for Mispar Hechrachi

[WolfCoder161]

Hi!

Is it possible to add support (maybe an arg in the gematria_to_int function) for Mispar Hechrachi (sofit letters are the same as their regular counterparts)?

Currently the library supports Mispar Gadol (where sofit letters extend alphabet after ת).

> python
Python 3.12.4 (tags/v3.12.4:8e8a4ba, Jun  6 2024, 19:30:16) [MSC v.1940 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from hebrew_numbers import gematria_to_int
>>> mem = "מ"
>>> mem_sofit = "ם"
>>> gematria_to_int(mem)
40
>>> gematria_to_int(mem_sofit) 
600

[ninjaaron]

I added a branch with this functionality. https://github.com/OriHoch/python-hebrew-numbers/tree/mispar_hechrechi

This adds an option to gematria_to_int.

>>> from hebrew_numbers import gematria_to_int
>>> gematria_to_int("ם")
600
>>> gematria_to_int("ם", mispar_hechrachi=True)
40

What do you think?

[WolfCoder161]

Hi, thanks for responding.

I see the new branch but no new commits. Did you push to the repo?

In terms of design, I was originally thinking that it would be something like a flag/arg (just as your demo above). Though I am thinking now that it might be useful to split the functionality for that (or an alias) to make it easier to use. Possibly something like:

>>> from hebrew_numbers import mispar_hechrachi
>>> mem_sofit = "ם"
>>> mispar_hechrachi.gematria_to_int(mem_sofit)
40
>>> mispar_hechrachi.int_to_gematria(140, gershayim=true)
'ק"ם'

[ninjaaron]

My bad. I pushed it now. The way you suggest looks good. I'll work on it tomorrow.

[WolfCoder161]

Hi.

The updated code looks good as a simple fix.