fix(transfer): stop folder downloads looping until they crash - #142
Merged
Conversation
Recursive listing had no memory of directories already seen, so an FTP cdir/pdir with a real path, a WebDAV self-href, or an SFTP directory symlink back to a parent was walked until the process ran out of memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdir/pdirwith a real path, a WebDAV self-href — or an SFTP directory symlink pointing back at an ancestor was walked until the process ran out of memory. That is the crash on downloading a folder, especially a large one: listing never finishes, progress stays at 0%, then the app dies.cdir/pdirregardless of how they are named.Test plan
cargo test -p portkeydrop-core --lib(528 passed)cargo clippy -p portkeydrop-core --all-targets -- -D warnings