Carry provider failure detail, name both providers, expose the Atlas-only knobs - #27
Merged
Merged
Conversation
…e the Atlas-only knobs The three nits recorded in the #13 review, in one bounded pass: - A failed/canceled poll now carries the provider's own reason — Atlas data.error and Doubao error.message — instead of a bare "task X failed". The response already said WHY; a refusal must hand that detail over. (Doubao had dropped it since before #13.) - The no-provider error names both configured choices (provider=doubao or provider=atlas); it still said doubao-only. - The Atlas-only generation knobs are now expressible end to end: ratio "adaptive" (follow the source/first frame), duration -1 (provider-chosen length, Atlas builder accepts it while Doubao keeps its 4-15 bound), and the -SR / 4k resolution variants — widened in VideoParams, the MCP schema (with Atlas-only notes), and the CLI descriptions. Values remain provider-checked: passing an Atlas-only value to Doubao fails at the provider with its own error, which is the BYO contract. Verified: build green; 222 tests pass (+4): Atlas failure detail, Doubao failure detail, both-providers message, and the -1/adaptive/ 1080p-SR pass-through with the 4-15-or--1 bound still enforced. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VL7mRpmEphLAbcH7YmABnV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three nits recorded in the #13 review, in one bounded pass. Stacked on #26 (same function); merge #26 first, then re-target this to main.
data.error/ Doubao'serror.message—video: task t9 failed: quota exceededinstead of a barefailed. (Doubao had been dropping it since before feat(video): add Atlas Cloud provider #13.)provider=doubao or provider=atlas).ratio: "adaptive",duration: -1(provider-chosen; the Atlas builder accepts it, Doubao keeps its 4–15 bound), and the-SR/4kresolutions — widened inVideoParams, the MCP schema (with Atlas-only notes), and the CLI descriptions. Values stay provider-checked: an Atlas-only value sent to Doubao fails at the provider with its own error, which is the BYO contract.Verification
Build green; 222 tests pass (+4): Atlas failure detail, Doubao failure detail, the both-providers message, and
-1/adaptive/1080p-SRpassing through the builder whileduration: 3still gets the 4–15-or-−1 refusal.🤖 Generated with Claude Code
https://claude.ai/code/session_01VL7mRpmEphLAbcH7YmABnV