docs(skill): generalize the proactive-feedback trigger beyond BEW/DPL codes - #59
Open
OS-joaocastilho wants to merge 2 commits into
Open
docs(skill): generalize the proactive-feedback trigger beyond BEW/DPL codes#59OS-joaocastilho wants to merge 2 commits into
OS-joaocastilho wants to merge 2 commits into
Conversation
… codes The remote MCP server now surfaces build-engine errors from any OS-* family (OS-BEW-*, OS-DPL-*, OS-RDBS-GEN-* and others), not only OS-BEW-*/OS-DPL-*. The bounded-exception rule for offering to file feedback after a clearly-broken tool call named only those two prefixes, so a failure carrying a different family's code silently missed the proactive prompt. All five skill docs (root SKILL.md, skills/outsystems/SKILL.md, cursor/skills/outsystems/SKILL.md, copilot/skill.md, kiro/outsystems/steering/skill.md) now name the general OS-* shape with BEW/DPL/RDBS-GEN as examples, kept in lockstep per this repo's own convention.
There was a problem hiding this comment.
Review verdict: clean -- converged in 1 round
Findings: 0 MUST, 0 SHOULD, 0 COULD
No inline comments.
What was checked
The diff touches five parallel skill docs (one-line wording change in the bounded-exception rule) and four plugin manifests (version bump 0.18.1 -> 0.18.2). No server code was changed.
Panel that ran:
docs-reviewer(any diff: manifests + skill docs qualify)consistency-reviewer(diff touches**/.claude-plugin/**,**/plugin.json,**/marketplace.json)error-handling-reviewer: SKIPPED (docs-only diff, no code changes)simplification-reviewer: SKIPPED (docs-only diff, no code changes)
Independent verification performed:
- Lockstep phrase
"platform build-engine failure code"across all five skill docs: 1/1/1/1/1 -- pass - Lockstep phrase
"OS-RDBS-GEN"across all five skill docs: 1/1/1/1/1 -- pass - Old exhaustive trigger
any OS-BEW-* or OS-DPL-* failure code(withoutOS-*umbrella): not present in any of the five bounded-exception trigger lines -- pass OS-BEW-*andOS-DPL-*remaining mentions are illustrative examples in the updated sentence and in unrelatederror_detailsnarrative prose, not exhaustive trigger conditions -- pass- All four manifest versions at
0.18.2:.claude-plugin/plugin.json,.claude-plugin/marketplace.json,cursor/.cursor-plugin/plugin.json,.cursor-plugin/marketplace.json-- pass kiro/outsystems/POWER.mddoes not carry the bounded-exception proactive-feedback rule and requires no update (the rule is agent-facing behavior, not operator-diagnostic, so the documented curated-subset policy correctly excludes it) -- pass
Challenged and dropped
No findings were raised and subsequently refuted. The panel produced no actionable candidates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The remote MCP server now surfaces build-engine errors from any
OS-*platform error code family (OS-BEW-*,OS-DPL-*,OS-RDBS-GEN-*, and others), not onlyOS-BEW-*/OS-DPL-*. The bounded-exception rule for proactively offering to file feedback after a clearly-broken tool call named only those two prefixes, so a failure carrying a different family's code silently missed the proactive prompt.All five lockstepped skill docs (
SKILL.md,skills/outsystems/SKILL.md,copilot/skill.md,cursor/skills/outsystems/SKILL.md,kiro/outsystems/steering/skill.md) now name the generalOS-*shape, withOS-BEW-*/OS-DPL-*/OS-RDBS-GEN-*kept as examples rather than the exhaustive list.commands/outsystems-feedback.mdmentions these prefixes only as illustrative example codes, not as a closed trigger condition, and needed no change.Version bumped
0.18.1->0.18.2(PATCH: a wording clarification that does not change how a user installs or invokes the integration).Harness coverage
This is a skill-doc wording change outside the setup/install recipe, so CLAUDE.md's "Skill-doc wording" tier applies (lockstep grep plus a read of the affected section), not the full per-harness install verification sequence.
kiro/outsystems/POWER.md: not touched, this rule does not appear there.commands/outsystems-feedback.md: checked, no closed-set OS-BEW/OS-DPL trigger present, no change needed.Test plan
OS-BEW/OS-DPLacross all markdown confirms only the five lockstepped skill docs matched, and all five now read the generalOS-*phrasing.grep -c 'OS-RDBS-GEN-\*'across the five docs returns 1/1/1/1/1 (lockstep check per CLAUDE.md).plugin.jsonx2,marketplace.jsonx2).