Skip to content

docs(skill): generalize the proactive-feedback trigger beyond BEW/DPL codes - #59

Open
OS-joaocastilho wants to merge 2 commits into
mainfrom
docs/generalize-bounded-exception-error-family
Open

docs(skill): generalize the proactive-feedback trigger beyond BEW/DPL codes#59
OS-joaocastilho wants to merge 2 commits into
mainfrom
docs/generalize-bounded-exception-error-family

Conversation

@OS-joaocastilho

Copy link
Copy Markdown
Contributor

Summary

The remote MCP server now surfaces build-engine errors from any OS-* platform error code family (OS-BEW-*, OS-DPL-*, OS-RDBS-GEN-*, and others), not only OS-BEW-*/OS-DPL-*. The bounded-exception rule for proactively offering to file feedback after a clearly-broken tool call named only those two prefixes, so a failure carrying a different family's code silently missed the proactive prompt.

All five lockstepped skill docs (SKILL.md, skills/outsystems/SKILL.md, copilot/skill.md, cursor/skills/outsystems/SKILL.md, kiro/outsystems/steering/skill.md) now name the general OS-* shape, with OS-BEW-*/OS-DPL-*/OS-RDBS-GEN-* kept as examples rather than the exhaustive list. commands/outsystems-feedback.md mentions these prefixes only as illustrative example codes, not as a closed trigger condition, and needed no change.

Version bumped 0.18.1 -> 0.18.2 (PATCH: a wording clarification that does not change how a user installs or invokes the integration).

Harness coverage

This is a skill-doc wording change outside the setup/install recipe, so CLAUDE.md's "Skill-doc wording" tier applies (lockstep grep plus a read of the affected section), not the full per-harness install verification sequence.

  • All five lockstepped docs: diffed against each other, identical one-line change in every file.
  • kiro/outsystems/POWER.md: not touched, this rule does not appear there.
  • commands/outsystems-feedback.md: checked, no closed-set OS-BEW/OS-DPL trigger present, no change needed.

Test plan

  • Repo-wide grep for OS-BEW/OS-DPL across all markdown confirms only the five lockstepped skill docs matched, and all five now read the general OS-* phrasing.
  • grep -c 'OS-RDBS-GEN-\*' across the five docs returns 1/1/1/1/1 (lockstep check per CLAUDE.md).
  • Confirmed the version bump landed in all four manifests (plugin.json x2, marketplace.json x2).

… codes

The remote MCP server now surfaces build-engine errors from any OS-*
family (OS-BEW-*, OS-DPL-*, OS-RDBS-GEN-* and others), not only
OS-BEW-*/OS-DPL-*. The bounded-exception rule for offering to file
feedback after a clearly-broken tool call named only those two
prefixes, so a failure carrying a different family's code silently
missed the proactive prompt. All five skill docs (root SKILL.md,
skills/outsystems/SKILL.md, cursor/skills/outsystems/SKILL.md,
copilot/skill.md, kiro/outsystems/steering/skill.md) now name the
general OS-* shape with BEW/DPL/RDBS-GEN as examples, kept in
lockstep per this repo's own convention.
@OS-joaocastilho
OS-joaocastilho requested a review from a team as a code owner September 7, 2026 09:02

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review verdict: clean -- converged in 1 round

Findings: 0 MUST, 0 SHOULD, 0 COULD

No inline comments.


What was checked

The diff touches five parallel skill docs (one-line wording change in the bounded-exception rule) and four plugin manifests (version bump 0.18.1 -> 0.18.2). No server code was changed.

Panel that ran:

  • docs-reviewer (any diff: manifests + skill docs qualify)
  • consistency-reviewer (diff touches **/.claude-plugin/**, **/plugin.json, **/marketplace.json)
  • error-handling-reviewer: SKIPPED (docs-only diff, no code changes)
  • simplification-reviewer: SKIPPED (docs-only diff, no code changes)

Independent verification performed:

  1. Lockstep phrase "platform build-engine failure code" across all five skill docs: 1/1/1/1/1 -- pass
  2. Lockstep phrase "OS-RDBS-GEN" across all five skill docs: 1/1/1/1/1 -- pass
  3. Old exhaustive trigger any OS-BEW-* or OS-DPL-* failure code (without OS-* umbrella): not present in any of the five bounded-exception trigger lines -- pass
  4. OS-BEW-* and OS-DPL-* remaining mentions are illustrative examples in the updated sentence and in unrelated error_details narrative prose, not exhaustive trigger conditions -- pass
  5. All four manifest versions at 0.18.2: .claude-plugin/plugin.json, .claude-plugin/marketplace.json, cursor/.cursor-plugin/plugin.json, .cursor-plugin/marketplace.json -- pass
  6. kiro/outsystems/POWER.md does not carry the bounded-exception proactive-feedback rule and requires no update (the rule is agent-facing behavior, not operator-diagnostic, so the documented curated-subset policy correctly excludes it) -- pass

Challenged and dropped

No findings were raised and subsequently refuted. The panel produced no actionable candidates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant