Skip to content

Release 2.132.1 #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaVulcan merged 2 commits into from
Feb 3, 2026
Merged

Release 2.132.1 #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2de24a
Hotfix: always render all sections and hide them using "hidden" attri…
luixlive Jan 31, 2026
a9c203e
Merge pull request #1440 from PADAS/conditiona-react-select-bug
JoshuaVulcan Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .yarn/install-state.gz
View file
Open in desktop
Binary file not shown.
2 changes: 2 additions & 0 deletions src/ReportManager/DetailsSection/SchemaForm/fields/Section/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const Section = ({
onFieldChange,
onFieldErrorsChange,
renderField,
...otherProps
}) => {
const onColumnFieldChange = (fieldId, value, error) => {
onFieldChange(fieldId, value);
Expand All @@ -22,6 +23,7 @@ const Section = ({
return <div
className={styles.section}
data-testid={`schema-form-section-${id}`}
{...otherProps}
>
{details.label && <h3 className={styles.header}>{details.label}</h3>}

Expand Down
6 changes: 6 additions & 0 deletions src/ReportManager/DetailsSection/SchemaForm/fields/Section/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ describe('ReportManager - DetailsSection - SchemaForm - fields - Section', () =>
{...props}
/>);

test('configures the section with other props', async () => {
renderSectionField({ hidden: true });

expect(screen.getByTestId('schema-form-section-section-1')).toHaveAttribute('hidden');
});

test('does not show a header if the label is not defined', async () => {
details.label = '';
renderSectionField();
Expand Down
3 changes: 2 additions & 1 deletion src/ReportManager/DetailsSection/SchemaForm/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,12 @@ const SchemaForm = ({
}, [formData, formElements, setLocationMarkers]);

return <form onSubmit={onSubmit}>
{visibleSectionIds.map((sectionId) => <Section
{formElements[ROOT_CANVAS_ID]?.details.sections.map((sectionId) => <Section
details={formElements[sectionId].details}
fieldErrors={fieldErrors}
focusLocationMarker={focusLocationMarker}
formData={formData}
hidden={!visibleSectionIds.includes(sectionId)}
id={sectionId}
key={sectionId}
onFieldChange={onSectionFieldChange}
Expand Down
4 changes: 2 additions & 2 deletions src/ReportManager/DetailsSection/SchemaForm/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,8 +397,8 @@ describe('ReportManager - DetailsSection - SchemaForm', () => {
expect(screen.getByTestId('schema-form-text-field-text_field_2')).toBeVisible();

// section-1 has condition text_field === "invalid", which fails, so it should not be visible
expect(screen.queryByTestId('schema-form-section-section-1')).toBeNull();
expect(screen.queryByTestId('schema-form-text-field-text_field_3')).toBeNull();
expect(screen.getByTestId('schema-form-section-section-1')).not.toBeVisible();
expect(screen.getByTestId('schema-form-text-field-text_field_3')).not.toBeVisible();
});

test('shows validation errors if there are any when the user submits the form', async () => {
Expand Down
Loading