Skip to content

Add User Details for Clinical Staff in t_visitdetails When a Patient Visits the Facility#219

Open
vanitha1822 wants to merge 18 commits into
release-3.9.0from
nd/vs/clinical_staff
Open

Add User Details for Clinical Staff in t_visitdetails When a Patient Visits the Facility#219
vanitha1822 wants to merge 18 commits into
release-3.9.0from
nd/vs/clinical_staff

Conversation

@vanitha1822

Copy link
Copy Markdown
Member

📋 Description

JIRA ID:

AMM-2015


✅ Type of Change

  • New feature (non-breaking change which adds functionality)

vanitha1822 and others added 18 commits July 14, 2026 14:18
…cilityID first

- Endpoint renamed from /getUserVanSpDetails to /getUserFacilityDetails
- Login reads facilityID from m_UserServiceRoleMapping first
- Van view as fallback for old users without role mapping

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…erral

- UPTSU endpoint accepts facilityID directly
- Old getWorklist(vanID) delegates to new getWorklistByFacilityID
- Skips Van→Facility lookup for new users

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When UI sends servicePointID=293 but facilityID is missing from payload,
derive facilityID from servicePointID so worklist query finds the record.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
facilityID present → use facilityID; else fall back to vanID (MMU/TM unchanged)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…worklist routing

- IemrMmuLoginServiceImpl: route HWC users through facilityID login path; throw clear error if no facility mapped
- FacilityLoginRepo: add queries to fetch facilityID from m_UserServiceRoleMapping
- VanSpokeController: pass actual exception message to UI for facility mapping errors
- BeneficiaryVisitDetail: add @transient facilityID field so nurse services can propagate it to generateVisitCode
- CommonNurseServiceImpl: generateVisitCode uses facilityID over vanID; capture facilityID before save
- All 10 nurse services + QuickConsultation: set facilityID on benVisitDetailsOBJ before save so generateVisitCode does not throw on null vanID

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add getUserFacilityOnlyDetails service method: checks facilityID only,
  throws error immediately if not mapped — no van fallback
- VanSpokeController: getUserFacilityDetails calls new method
- Old getUserVanSpDetails (with van fallback) retained for MMU/TM path only
- If old user has both vanID and facilityID mapped, facilityID is used

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5acfe0d8-1101-4a46-ac07-fb7f0675ffc7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vanitha1822
vanitha1822 requested a review from vishwab1 July 23, 2026 10:06
@vanitha1822 vanitha1822 self-assigned this Jul 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
18.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants