Skip to content

Conversation

@changeyoung98
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

APIs

Description

Fix FC lora resume loss

@paddle-bot
Copy link

paddle-bot bot commented Nov 14, 2025

Thanks for your contribution!

llbdyiu66
llbdyiu66 previously approved these changes Nov 14, 2025
@changeyoung98
Copy link
Contributor Author

/re-run all-failed

zjjlivein pushed a commit that referenced this pull request Nov 14, 2025
Co-authored-by: zhengshengning <[email protected]>
@changeyoung98
Copy link
Contributor Author

/re-run all-failed

1 similar comment
@changeyoung98
Copy link
Contributor Author

/re-run all-failed

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@2d8aff9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/trainer/trainer.py 0.00% 13 Missing ⚠️
paddleformers/peft/lora/lora_layers.py 38.46% 8 Missing ⚠️
paddleformers/peft/lora/lora_model.py 68.42% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2950   +/-   ##
==========================================
  Coverage           ?   31.41%           
==========================================
  Files              ?      420           
  Lines              ?    68479           
  Branches           ?        0           
==========================================
  Hits               ?    21513           
  Misses             ?    46966           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@llbdyiu66 llbdyiu66 merged commit 8dd78c9 into PaddlePaddle:develop Nov 17, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants