Repository navigation
Support the FieldMap based persistency from PandoraSDK v03 - #49
Merged
Merged
Conversation
jmcarcell
force-pushed
the
pandorasdk-fieldmap-persistency
branch
from
October 7, 2026 17:28
02203bd to
92c937d
Compare
tmadlener
reviewed
Oct 7, 2026
tmadlener
approved these changes
Oct 7, 2026
tmadlener
left a comment
tmadlener
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. I am not sure if we ever use persistency via Pandora in any case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PandoraSDK changed in PandoraPFAOrg/PandoraSDK#38 the object factory persistency interface to
Read(Parameters&, const FieldMap&)/Write(const Object*, FieldMap&), which breaks the build:LCTrackFactorynow uses the new interface whenPersistency/FieldMap.his available and keeps the old implementation otherwise, so it builds with both versions.