Only copy over the direct superclass of our terms from other ontologies#20
Draft
arteymix wants to merge 5 commits into
Draft
Only copy over the direct superclass of our terms from other ontologies#20arteymix wants to merge 5 commits into
arteymix wants to merge 5 commits into
Conversation
arteymix
force-pushed
the
wip/remove-imports
branch
2 times, most recently
from
adb6548 to
806b2c0
Compare
arteymix
force-pushed
the
wip/remove-imports
branch
from
24f660b to
d14f0c1
Compare
ppavlidis
reviewed
Nov 26, 2023
ppavlidis
left a comment
ppavlidis
left a comment
Contributor
There was a problem hiding this comment.
I think I understand what you are saying but you might need to explain why this is a concern? Performance(
We don't use GENO separately except via TGEMO and only need a few terms from it, and are unlikely to use many other ones.
arteymix
force-pushed
the
wip/remove-imports
branch
from
d14f0c1 to
1e2617a
Compare
Contributor
Author
|
Yes, this is about performance for both Gemma but also QoL for curators that have to wait 5 minutes for Protégé to load right now. |
arteymix
force-pushed
the
wip/remove-imports
branch
from
1e2617a to
c0bb38f
Compare
Contributor
Author
|
I've addressed the issue of inference across ontologies in PavlidisLab/Gemma@4300e77, and I already went ahead with disabling import for TGEMO in tests to speed them up. This will be in the 1.31, so I'll wait until it's out before merging. |
arteymix
added a commit
to PavlidisLab/Gemma
that referenced
this pull request
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it much easier to work with the ontology file and in principle shouldn't affect our ability to perform ontology inference.
I have to check first if the inference with Gemma still works properly as we would be lacking the full set of super/sub-class hierarchy and part of/has part relations.