Skip to content

Conversation

@heavycrystal
Copy link
Contributor

No description provided.

@heavycrystal heavycrystal requested a review from Copilot October 9, 2025 12:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates MySQL connection testing by replacing Ping() calls with ConnectionActive() calls in test files and enhances the ConnectionActive() method to perform both connection ping and query execution checks.

  • Replaces Ping() method calls with ConnectionActive() in AWS RDS IAM authentication tests
  • Updates ConnectionActive() implementation to perform connection ping before executing test query
  • Adds error logging for both ping failures and query execution failures

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
flow/connectors/mysql/rds_test.go Updates test methods to use ConnectionActive() instead of Ping()
flow/connectors/mysql/mysql.go Enhances ConnectionActive() to include connection ping and improved error handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants