-
Notifications
You must be signed in to change notification settings - Fork 157
Challenge-1 #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Challenge-1 #3677
Conversation
…ger, and index migration support (with tests)
Testing |
| switch dstPgConn := any(dstConn).(type) { | ||
| case *connpostgres.PostgresConnector: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use type assertion like in flowable.go
| // MigrateTriggersAndIndexesForPostgresToPostgres migrates triggers and indexes | ||
| // from source to target for Postgres-to-Postgres flows. | ||
| // This should be called after schema deltas are replayed or during initial setup. | ||
| func (c *PostgresConnector) MigrateTriggersAndIndexesForPostgresToPostgres( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this is method & other methods are free standing functions in migration.go
Improve PeerDB for Postgres-to-Postgres migrations — add schema, trigger, and index migration support (with tests)