Support TIME64 data type for ClickHouse replication #3691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NehharShah
requested a deployment
to
external-contributor
GitHub Actions
Waiting
|
|
NehharShah
temporarily deployed
to
external-contributor
GitHub Actions
Inactive
NehharShah
temporarily deployed
to
external-contributor
GitHub Actions
Inactive
NehharShah
had a problem deploying
to
external-contributor
GitHub Actions
Failure
serprex
approved these changes
Nov 13, 2025
jgao54
reviewed
Nov 13, 2025
flow/e2e/clickhouse_mysql_test.go
Outdated
|
|
||
| // If ClickHouse >= 25.6 and using latest internal version, should use Time64(3) | ||
| if major > 25 || (major == 25 && minor >= 6) { | ||
| if flowConnConfig.Version >= shared.InternalVersion_ClickHouseTime64 { |
Contributor
There was a problem hiding this comment.
nit: we currently don't run CI against different versions of PeerDB/ClickHouse, could you add an explicit test case for an older version to verify backwards compatibility by setting something like flowConnConfig.Version = shared.InternalVersion_First
NehharShah
requested a deployment
to
external-contributor
GitHub Actions
Waiting
NehharShah
requested a deployment
to
external-contributor
GitHub Actions
Waiting
NehharShah
requested a deployment
to
external-contributor
GitHub Actions
Waiting
NehharShah
requested a deployment
to
external-contributor
GitHub Actions
Waiting
NehharShah
temporarily deployed
to
external-contributor
GitHub Actions
Inactive
NehharShah
temporarily deployed
to
external-contributor
GitHub Actions
Inactive
NehharShah
temporarily deployed
to
external-contributor
GitHub Actions
Inactive
NehharShah
temporarily deployed
to
external-contributor
GitHub Actions
Inactive
Contributor
|
Heads up: had to revert this PR, tests were failing on main but for some reason were not triggered with this PR (maybe due to stale merge base?) Haven't gotten a chance to look at it in details yet. |
jgao54
added a commit
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ClickHouse
TIME64(3)data type when replicating TIME columns from PostgreSQL and MySQL sources.Changes:
InternalVersion_ClickHouseTime64for backward compatibilityTIMEtype toQValueKindTime(instead ofQValueKindTimestamp) for new mirrorsTime64(3)for ClickHouse 25.6+ when internal version >=InternalVersion_ClickHouseTime64DateTime64(6)for older ClickHouse versions or existing mirrorsTime64(3)columnsBackward Compatibility:
DateTime64(6)Time64(3)DateTime64(6)Fixes #3468