Merged
Conversation
mpgn
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--dirfor WinRM, just a bit convenience (and makes it similar to smb).Also fixes a bug in
--get-filewhere the auto completion of the local path was borked because it didn't properly differentiate between linux and Windows paths.Fyi, also changed the default encoding to pysrp's default, because otherwise it would crash while decoding german characters such as
ä.Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
nxc winrm ... --dirnxc winrm ... --get-file '\remote\path\file' ./this would result in./\remote\path\filewhich should actually be./file.Screenshots (if appropriate):