Skip to content

Add WinRM dir command#1201

Merged
NeffIsBack merged 5 commits intomainfrom
neff-add-winrm-dir
Apr 14, 2026
Merged

Add WinRM dir command#1201
NeffIsBack merged 5 commits intomainfrom
neff-add-winrm-dir

Conversation

@NeffIsBack
Copy link
Copy Markdown
Member

@NeffIsBack NeffIsBack commented Apr 14, 2026

Description

Adds --dir for WinRM, just a bit convenience (and makes it similar to smb).
Also fixes a bug in --get-file where the auto completion of the local path was borked because it didn't properly differentiate between linux and Windows paths.
Fyi, also changed the default encoding to pysrp's default, because otherwise it would crash while decoding german characters such as ä.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

  1. nxc winrm ... --dir
  2. When doing nxc winrm ... --get-file '\remote\path\file' ./ this would result in ./\remote\path\file which should actually be ./file.
  3. Query a german host

Screenshots (if appropriate):

image image image

@NeffIsBack NeffIsBack added enhancement New feature or request bug-fix This Pull Request fixes a bug labels Apr 14, 2026
@Pennyw0rth Pennyw0rth deleted a comment from github-actions bot Apr 14, 2026
@NeffIsBack NeffIsBack merged commit cb8912a into main Apr 14, 2026
12 checks passed
@NeffIsBack NeffIsBack deleted the neff-add-winrm-dir branch April 14, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This Pull Request fixes a bug enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants