Add exclude options based on @bdrogja's work #732#1204
Open
Dfte wants to merge 2 commits intoPennyw0rth:mainfrom
Open
Add exclude options based on @bdrogja's work #732#1204Dfte wants to merge 2 commits intoPennyw0rth:mainfrom
Dfte wants to merge 2 commits intoPennyw0rth:mainfrom
Conversation
added 2 commits
April 15, 2026 11:15
Member
|
Nice! Thanks for the work. |
Member
|
@Marshall-Hallenbeck the PR description check crashed again |
Contributor
Author
I think because I removed the setup # |
Member
Naa it should comment and yell at you, not fail to run |
Contributor
Author
|
Thinking of how I'd use this PR, I'd also add the options that were developed by @bdrojga vefor (--exlude-hosts and --skip-self) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR to continue @bdrogja work from #732.
This PR adds two new config options allowing to exclude some IP's from NetExec and excluding local IP's as well:
The exclude_hosts option is an array that can take multiple type of values:
For example:
As @bdrogja mentions, this PR also closes #674.
I don't know if the test.py part is relevant anymore tho.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Checklist :
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)