fix(windows): keep WinUI callbacks behind scanned keys

[proggeramlug]

Summary

• keep raw WinUI widget callback pointers solely in the GC-scanned NODES table and have Reactor handlers resolve them by widget handle and callback slot at invocation
• keep timer callbacks in a scanned key-indexed table, and make application-exit and timer closures re-read live slots after a moving collection
• cover every widget callback slot plus lifecycle and timer indirection with Windows unit tests

Related issue

Fixes #8734

Test plan

• cargo fmt -p perry-ui-windows-winui -- --check
• cargo check -p perry-ui-windows-winui --all-targets
• cargo build --release -p perry-ui-windows-winui
• $env:RUSTFLAGS = '-C link-arg=/FORCE:MULTIPLE'; cargo test -p perry-ui-windows-winui --lib reactor_callback_keys (2 passed)
• python scripts/workspace_architecture.py --check --print-summary
• GC/runtime audits: store-site inventory, address-class inventory, snapshot self-test, test registration, runtime root holders, and scanner latches
• git diff --check
• no version bump or aggregate changelog edits

Notes

The focused tests use /FORCE:MULTIPLE locally because ordinary Windows lib-test linking currently encounters pre-existing duplicate perry_audio_* exports between perry-ui-windows and perry-audio-miniaudio (LNK2005). Clippy is also blocked before reaching this crate by the existing mistyped 0x0071_7263_i64 suffix in perry-ui-windows/src/widgets/qrcode.rs. Package formatting, all-target checking, the release build, and the focused regression tests pass.

Summary by CodeRabbit

• Bug Fixes
  • Fixed WinUI widget interactions, including buttons, text fields, toggles, sliders, and secure fields, so callbacks continue working reliably after garbage collection.
  • Improved timer, application activation, and application-exit callbacks to prevent stale or missed event handling.
  • Ensured event-driven UI behavior remains stable while applications are running and updating.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 695f78d6-93df-476c-aed2-3ea0d8964457

📥 Commits

Reviewing files that changed from the base of the PR and between 20a3889 and 62d8f6d.

📒 Files selected for processing (3)

• changelog.d/8734-winui-callback-indirection.md
• crates/perry-ui-windows-winui/src/app.rs
• crates/perry-ui-windows-winui/src/widgets.rs

Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

WinUI lifecycle, timer, and widget callbacks now use GC-scanned slots and stable keys. Invocation resolves the current callback instead of using raw pointers captured by Reactor closures. Tests cover rewritten application and widget callback slots.

Changes

WinUI callback indirection

Layer / File(s)	Summary
Application and timer callback slots crates/perry-ui-windows-winui/src/app.rs, changelog.d/8734-winui-callback-indirection.md	Activation, termination, and timer callbacks resolve through scanned slots. Pending timers store callback keys. Tests verify updated slot values are observed.
Widget callback lookup and rendering crates/perry-ui-windows-winui/src/widgets.rs	Widget handlers resolve callbacks from live nodes by handle and slot. Render paths pass handles into common handlers. Tests cover control callback types and button precedence.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 62d8f

The PR confines WinUI and timer callbacks to GC-scanned indirection tables and adds Windows regression coverage; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: keeping WinUI callbacks behind GC-scanned keys.
Description check	✅ Passed	The description explains the fix, links issue #8734, and documents validation, but omits the template's Changes and Checklist sections.
Linked Issues check	✅ Passed	The changes satisfy issue #8734 by resolving widget, lifecycle, and timer callbacks from scanned storage at invocation time.
Out of Scope Changes check	✅ Passed	The changes remain within the linked issue scope and add related documentation and regression tests.
Docstring Coverage	✅ Passed	Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/8734-winui-callback-indirection

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}