fix(cli): use /apps endpoint for cvms list to show only user's CVMs #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin users were seeing all CVMs on the platform when running `phala cvms list` due to the /cvms/paginated endpoint returning all CVMs for admin users. Changes: - Add new SDK action `getAppsList` for /apps endpoint - Update CLI `cvms list` to use /apps endpoint with proper pagination - Fix SDK tests to use viem's mainnet export instead of hardcoded chain - Update error message tests to include 'name' option The /apps endpoint returns only the current user's apps, fixing the issue for admin users. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
📋 Check Results✨ JS SDK - Code FormattingShow format check results🔍 JS SDK - TypeScript Type CheckShow type check output🧪 JS SDK - Test ResultsShow test output📝 JS SDK - Lint CheckShow lint results🌐 JS SDK - Browser CompatibilityShow browser test results🌐 Browser Compatibility ReportBrowser compatibility tests completed across:
The SDK has been verified to work in modern browser environments. Check run: https://github.com/Phala-Network/phala-cloud/actions/runs/19792774874 |
Collaborator
|
This would be a breaking change for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getAppsListfor/appsendpoint that returns only the current user's appscvms listto use/appsendpoint with proper pagination (fetches all pages)mainnetexport instead of hardcoded chain definitionsProblem
Admin users were seeing all CVMs on the platform when running
phala cvms listdue to the/cvms/paginatedendpoint returning all CVMs for admin users.Solution
Switch to the
/appsendpoint which correctly returns only the current user's apps regardless of admin status.Test plan
🤖 Generated with Claude Code