Skip to content

Conversation

@tillpp
Copy link
Contributor

@tillpp tillpp commented Dec 13, 2025

Most Monitors can display more FPS then 144Hz.
This make the FPS Slider pick one of the values from this Preset instead:

5, 10, 15, 30, 50, 60, 75, 90, 100, 120, 144, 165, 170, 180, 200, 240, 260, 280, 300, 360, 480, unlimited

Credit: Mischol (@thcae) idea and request

@Argmaster
Copy link
Collaborator

There are also 720Hz moniors 😝

@Bloxxel64
Copy link

could also just make it an entry field

@Argmaster Argmaster moved this to Easy to Review in PRs to review Dec 14, 2025
@tillpp
Copy link
Contributor Author

tillpp commented Dec 17, 2025

Request for Review

@IntegratedQuantum
Copy link
Member

Request for Review

If it's on the issue board then I will review it as soon as I get around to it. Commenting doesn't make this any faster.

Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain where you got these values? They look quite random.

Also at this point I think a DiscreteSlider would be the better choice to have more even spacing between adjacent values.

@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to In review in PRs to review Dec 18, 2025
@tillpp
Copy link
Contributor Author

tillpp commented Dec 18, 2025

Request for Review

If it's on the issue board then I will review it as soon as I get around to it. Commenting doesn't make this any faster.

ok, just thought you might have forgotten that this exist, or overlooked this
Didnt want this getting closed for inactivity by a bot

@Argmaster
Copy link
Collaborator

Argmaster commented Dec 18, 2025

I think they mostly align with what you could find in filters of a tech shop.

Edit:
Screenshots from a Polish tech importer:
Screenshot_2025-12-18-17-43-06-884_pl xkom-edit
Screenshot_2025-12-18-17-45-10-359_pl xkom-edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants