-
Notifications
You must be signed in to change notification settings - Fork 187
Hide gui #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide gui #2436
Conversation
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this behavior maybe apply to all menu keys (inventory, creative inventory, chat, ...)? In that case I think it should be added to the toggleGameMenu function.
I don't quite understand what you mean.. But while I looked at this I found that the guis are only hidden but you can still write in the chat. I will open an Issue for that |
If you press |
|
Would this then not go against why we wanted to only ESC have this function? Reference: #2343 (comment) |
|
Well, for taking the screenshot you could still hide the gui again with F1 when you are in the inventory/menu. |
|
done |
|
there is some wierd bug for me now. So please wait |
|
removed the return. Now it unhides and opens inventory chat etc at the same time, but else there would be many cases where I would need to put the if(hideGui). Example for when opening the chat. Now #2448 is fixed but you can still hide the gui while writing in the chat |
Fixes: #2343
fixes #2448