Skip to content

Conversation

@Wunka
Copy link
Contributor

@Wunka Wunka commented Dec 27, 2025

Fixes: #2343
fixes #2448

@Argmaster Argmaster moved this to Easy to Review in PRs to review Dec 30, 2025
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this behavior maybe apply to all menu keys (inventory, creative inventory, chat, ...)? In that case I think it should be added to the toggleGameMenu function.

@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to In review in PRs to review Dec 30, 2025
@Wunka
Copy link
Contributor Author

Wunka commented Dec 30, 2025

Should this behavior maybe apply to all menu keys (inventory, creative inventory, chat, ...)? In that case I think it should be added to the toggleGameMenu function.

I don't quite understand what you mean.. But while I looked at this I found that the guis are only hidden but you can still write in the chat. I will open an Issue for that

@IntegratedQuantum
Copy link
Member

I don't quite understand what you mean..

If you press t to open chat, or e to open inventory, then maybe we should also unhide the GUI, since you likely want to go to the inventory or chat, but you cannot see it if it's hidden.

@Wunka
Copy link
Contributor Author

Wunka commented Dec 31, 2025

Would this then not go against why we wanted to only ESC have this function? Reference: #2343 (comment)

@IntegratedQuantum
Copy link
Member

Well, for taking the screenshot you could still hide the gui again with F1 when you are in the inventory/menu.

@Wunka
Copy link
Contributor Author

Wunka commented Dec 31, 2025

done

@Wunka
Copy link
Contributor Author

Wunka commented Dec 31, 2025

there is some wierd bug for me now. So please wait

@Wunka
Copy link
Contributor Author

Wunka commented Dec 31, 2025

removed the return. Now it unhides and opens inventory chat etc at the same time, but else there would be many cases where I would need to put the if(hideGui). Example for when opening the chat. Now #2448 is fixed but you can still hide the gui while writing in the chat

@IntegratedQuantum IntegratedQuantum merged commit 5a0f576 into PixelGuys:master Jan 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

When the gui is hidden you can stil write in the chat without realizing it When the GUI is hidden and ESC is pressed the GUI is still hidden

2 participants