Skip to content

deps: Update ashpd to 0.11 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

deps: Update ashpd to 0.11 #240

merged 1 commit into from
Mar 10, 2025

Conversation

@torokati44
Copy link
Contributor

@torokati44 torokati44 commented Feb 18, 2025

Continuing #220...
The dependency deduplication is blocked on a new release of ppv-lite86 (cryptocorrosion/cryptocorrosion#83 (comment)) (for zerocopy and zerocopy-derive), and on tokio-rs/mio#1836, I think (for wasi).

@torokati44 torokati44 mentioned this pull request Feb 18, 2025
Closed
@valadaptive
Copy link
Contributor

valadaptive commented Mar 7, 2025

This appears to be necessary for things to build now, dependency duplication or not--bilelmoussaoui/ashpd#264 means the current version of rfd no longer builds.

@torokati44
Copy link
Contributor Author

torokati44 commented Mar 10, 2025

A new version of ppv-lite86 just got released, so the only blocker remaining is tokio-rs/mio#1836.

@torokati44 torokati44 marked this pull request as ready for review March 10, 2025 13:05
@torokati44
Copy link
Contributor Author

torokati44 commented Mar 10, 2025

Oh, it turns out, the wasi duplication is only apparent when looking at Cargo.lock by eye, but in reality none of the target triples actually pull in both 0.11 and 0.13...?! I guess this crate only makes sense for WASM targets, and only wasm32-unknown-unknown of those is checked by cargo-deny.
So, is it possible that this is mergeable after all? 👀

@PolyMeilex
Copy link
Owner

PolyMeilex commented Mar 10, 2025

Yep, this is totally fine, thanks!

@PolyMeilex PolyMeilex merged commit 24842c4 into PolyMeilex:master Mar 10, 2025
13 checks passed
@torokati44 torokati44 mentioned this pull request Mar 10, 2025
Closed
@torokati44
Copy link
Contributor Author

torokati44 commented Mar 11, 2025

Do you think we could get a release on crates.io with this in it sometime soon? 🙏 Thank you!

@valadaptive valadaptive mentioned this pull request Mar 12, 2025
Merged
lucasmerlin added a commit to emilk/egui that referenced this pull request Mar 20, 2025
@valadaptive @lucasmerlin
Bump accesskit to 0.18 and make it a workspace dependency (#5783)
d0bd525 
This can't be merged until [kittest's accesskit is
bumped](rerun-io/kittest#9) ~~and [a new version
of rfd is released](PolyMeilex/rfd#240.

---------

Co-authored-by: Lucas Meurer <[email protected]>
@kjarosh
Copy link
Contributor

kjarosh commented Jul 7, 2025

That unfortunately broke some things on Wayland, due to bilelmoussaoui/ashpd@ba5a5d7 🫤

Before 0.11 the wayland feature was enabled automatically for raw_handle, now it isn't.

@kjarosh kjarosh mentioned this pull request Jul 7, 2025
Merged
darkwater pushed a commit to darkwater/egui that referenced this pull request Aug 24, 2025
@valadaptive @lucasmerlin @darkwater
Bump accesskit to 0.18 and make it a workspace dependency (emilk#5783)
67e9435 
This can't be merged until [kittest's accesskit is
bumped](rerun-io/kittest#9) ~~and [a new version
of rfd is released](PolyMeilex/rfd#240.

---------

Co-authored-by: Lucas Meurer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@torokati44 @valadaptive @PolyMeilex @kjarosh