Add 1.21.5 Support & Rework Code Structure #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyvest
requested changes
Sep 16, 2025
src/main/java/org/polyfrost/polyhitbox/mixin/MixinLineStateShard.java
Outdated
Show resolved
Hide resolved
| if (hitboxInfo.showMode != 2) enabled = true | ||
| hitboxesEnabled = enabled | ||
|
|
||
| // TODO: FIX |
Author
There was a problem hiding this comment.
yes because i dont know math
Wyvest
requested changes
Sep 16, 2025
src/main/java/org/polyfrost/polyhitbox/mixin/MixinLineStateShard.java
Outdated
Show resolved
Hide resolved
|
|
||
| HitboxRendererKt.renderHitbox( | ||
| stack, | ||
| new HitboxState( |
Member
There was a problem hiding this comment.
cant we just pass all the variables here instead of creating a new HitboxState every time we want to render a hithbox
src/main/java/org/polyfrost/polyhitbox/mixin/MixinRenderManager.java
Outdated
Show resolved
Hide resolved
Author
|
fixed the stuff |
Wyvest
requested changes
Sep 25, 2025
Member
Wyvest
left a comment
Wyvest
left a comment
There was a problem hiding this comment.
Looks ok but does this do per-entity customization?
| if (hitboxInfo.showMode != 2) enabled = true | ||
| hitboxesEnabled = enabled | ||
|
|
||
| // TODO: FIX |
Wyvest
requested changes
Sep 25, 2025
| //#else | ||
| //$$ private void polyhitbox$customRendering(Entity entity, double offsetX, double offsetY, double offsetZ, float yaw, float tickDelta, CallbackInfo ci) { | ||
| //#endif | ||
| ci.cancel(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 1.12, and 1.21.5 support with some code refactoring/cleanup