docs: improve token ID placeholders and add wallet funding note#72
Open
contbytex wants to merge 2 commits into
Open
docs: improve token ID placeholders and add wallet funding note#72contbytex wants to merge 2 commits into
contbytex wants to merge 2 commits into
Conversation
docs: improve token ID placeholders and add wallet funding note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the developer experience in the CLI documentation by addressing a few minor points:
48331043336612883...) with the generic<TOKEN_ID>placeholder across the examples. This prevents confusion for users who might try to copy/paste the commands directly.polymarket wallet show) and fund it with MATIC and USDC.e on Polygon before attempting to runpolymarket approve set.These minor changes should help reduce friction for users setting up the CLI for the first time.
Note
Low Risk
Low risk documentation-only changes; no runtime behavior or API contracts are modified.
Overview
Updates
README.mdexamples to use generic placeholders (e.g.,<TOKEN_ID>,0xCONDITION_ID,0xCOLLECTION_ID) instead of copy-pastable real-looking IDs, and adds a note in Contract Approvals about funding the generated wallet (view viapolymarket wallet show, fund with MATIC/USDC.e on Polygon) before runningpolymarket approve set.Also tweaks markdown formatting for code blocks (use
textfences) and simplifies sample JSON output so it doesn’t imply omitted fields.Reviewed by Cursor Bugbot for commit 3a4fd63. Bugbot is set up for automated code reviews on this repo. Configure here.