Skip to content

bug: type top_p as float in Completion.create #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug: type top_p as float in Completion.create #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions portkey_ai/api_resources/apis/complete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def create(
stream: Union[bool, NotGiven] = NOT_GIVEN,
temperature: Union[float, NotGiven] = NOT_GIVEN,
max_tokens: Union[int, NotGiven] = NOT_GIVEN,
top_p: Union[bool, NotGiven] = NOT_GIVEN,
top_p: Union[float, NotGiven] = NOT_GIVEN,
best_of: Union[int, NotGiven] = NOT_GIVEN,
echo: Union[bool, NotGiven] = NOT_GIVEN,
frequency_penalty: Union[float, NotGiven] = NOT_GIVEN,
Expand Down Expand Up @@ -317,7 +317,7 @@ async def create(
stream: Union[bool, NotGiven] = NOT_GIVEN,
temperature: Union[float, NotGiven] = NOT_GIVEN,
max_tokens: Union[int, NotGiven] = NOT_GIVEN,
top_p: Union[bool, NotGiven] = NOT_GIVEN,
top_p: Union[float, NotGiven] = NOT_GIVEN,
best_of: Union[int, NotGiven] = NOT_GIVEN,
echo: Union[bool, NotGiven] = NOT_GIVEN,
frequency_penalty: Union[float, NotGiven] = NOT_GIVEN,
Expand Down
20 changes: 20 additions & 0 deletions tests/test_complete_top_p_annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import inspect
import typing

from portkey_ai import AsyncCompletion, Completion


def test_completion_top_p_is_typed_as_float():
annotation = inspect.signature(Completion.create).parameters["top_p"].annotation
args = typing.get_args(annotation)
assert float in args
assert bool not in args


def test_async_completion_top_p_is_typed_as_float():
annotation = (
inspect.signature(AsyncCompletion.create).parameters["top_p"].annotation
)
args = typing.get_args(annotation)
assert float in args
assert bool not in args