Draft
Conversation
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
|
Member
vincentkoppen
left a comment
vincentkoppen
left a comment
There was a problem hiding this comment.
Whether needed or not, seems like a sensible change any way to me.
This way the input_data if looked at, is much easier to understand for the user.
| loaded_grid = Grid.deserialize(path) | ||
| assert loaded_grid == grid | ||
|
|
||
| @pytest.mark.parametrize("grid_fixture", ("basic_grid", "grid")) |
Member
There was a problem hiding this comment.
Any specific reason we should test on grid anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting to a pgm_input_dict, we should not include empty arrays.
Reasons:
PGM's validate_input_data does not seem to support empty arrays.There is something else going on. I want to investigate once Add grid.diff() method and diff utils #176 is mergedNote: As @mgovers suggested, this is technically a breaking change (different set of dict keys in pgm_input dict). Though I doubt it will have much impact.