chore: refactor mimalloc import #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, users of the plugin might prefer to use a dynamically linked version of mimalloc. This PR introduces a new CMake option allowing to dynamically link mimalloc. Unlike [media-kit#883](media-kit#883) , this PR does **not** change the default behavior but simply adds an additional CMake option. **The default behavior of the plugin is not changed.** If users set the CMake option : ```cmake set(MIMALLOC_USE_STATIC_LIBS OFF) ``` This plugin will now link against the system-provided mimalloc. Users might prefer this in case they try to reduce installation size or aim to comply with distributor-specific dependency management requirements. Unless this option is set to `OFF`, the behavior of the plugin won't change. Thanks a lot for your amazing work 🎉 ! - chore: refactor mimalloc import - fix: correct minimum required CMake version - chore: better format if statement Signed-off-by: The one with the braid <[email protected]>
Owner
|
I'm sorry I've only just seen this PR. Since this is a forked repository, I didn’t receive any email notifications about it. Could you please confirm whether you intended to submit the PR to this low-traffic branch instead of the main branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, users of the plugin might prefer to use a dynamically linked version of mimalloc. This PR introduces a new CMake option allowing to dynamically link mimalloc. Unlike #883 , this PR does not change the default behavior but simply adds an additional CMake option.
The default behavior of the plugin is not changed.
If users set the CMake option :
This plugin will now link against the system-provided mimalloc.
Users might prefer this in case they try to reduce installation size or aim to comply with distributor-specific dependency management requirements.
Unless this option is set to
OFF, the behavior of the plugin won't change.Thanks a lot for your amazing work 🎉 !